test: add golden files and RunWithSuggestedFixes for 3 autofix linters by Copilot · Pull Request #43376 · github/gh-aw

Copilot · 2026-07-04T11:13:31Z

3 of 9 SuggestedFix-emitting linters (stringsindexcontains, sprintfint, stringreplaceminusone) used analysistest.Run, which only validates diagnostic positions/messages — never the actual text edits. Their fix builders were completely unexercised.

Changes

Golden files added for each linter capturing exact post-fix source:
- stringsindexcontains: all 6 comparison forms + 4 yoda variants → strings.Contains/!strings.Contains
- sprintfint: fmt.Sprintf("%d", x) → strconv.Itoa(x) (int variable and literal)
- stringreplaceminusone: strings.Replace(..., -1) → strings.ReplaceAll(...) (literal and named constant)
Test entrypoints switched from analysistest.Run → analysistest.RunWithSuggestedFixes, matching the pattern already used by fprintlnsprintf, lenstringzero, tolowerequalfold, etc.

No production analyzer code changed.

Generated by 👨‍🍳 PR Sous Chef · 8.21 AIC · ⌖ 6.19 AIC · ⊞ 3.4K · ◷
_{Comment /souschef to run again}

…r 3 linters Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

…contains, sprintfint, stringreplaceminusone Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions · 2026-07-04T12:44:08Z

🤖 PR Triage — Run §28706384347

Field	Value
Category	`test`
Risk	🟢 Low
Score	48 / 100
Action	🔄 `batch_review`
Batch	`pr-batch:draft-backlog`

Score breakdown: impact 22 + urgency 12 + quality 14

Adds golden files and RunWithSuggestedFixes for 3 autofix linters (stringsindexcontains, sprintfint, stringreplaceminusone). +147/-3 in 6 files. Draft — no CI yet. Low urgency, batch with other test coverage PRs.

Generated by 🔧 PR Triage Agent · 56.5 AIC · ⌖ 8.62 AIC · ⊞ 5.5K · ◷

Copilot

Pull request overview

This PR strengthens linter autofix testing by switching three analyzers’ tests to validate their SuggestedFix text edits via golden files, rather than only validating diagnostic locations/messages.

Changes:

Added .golden fixtures for stringsindexcontains, sprintfint, and stringreplaceminusone to assert exact post-fix output.
Updated the three linter tests to use analysistest.RunWithSuggestedFixes so suggested fixes are exercised and verified.
Kept analyzer implementations unchanged; changes are limited to test harness + fixtures.

Show a summary per file

File	Description
pkg/linters/stringsindexcontains/testdata/src/stringsindexcontains/stringsindexcontains.go.golden	Golden output validating the `strings.Index(...)` containment comparisons are rewritten to `strings.Contains` forms.
pkg/linters/stringsindexcontains/stringsindexcontains_test.go	Switches test runner to `RunWithSuggestedFixes` to verify fixes against the golden file.
pkg/linters/stringreplaceminusone/testdata/src/stringreplaceminusone/stringreplaceminusone.go.golden	Golden output validating `strings.Replace(..., -1)` is rewritten to `strings.ReplaceAll(...)`.
pkg/linters/stringreplaceminusone/stringreplaceminusone_test.go	Switches test runner to `RunWithSuggestedFixes` to verify fixes against the golden file.
pkg/linters/sprintfint/testdata/src/sprintfint/sprintfint.go.golden	Golden output validating `fmt.Sprintf("%d", x)` is rewritten to `strconv.Itoa(x)` for `int`.
pkg/linters/sprintfint/sprintfint_test.go	Switches test runner to `RunWithSuggestedFixes` to verify fixes against the golden file.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 6/6 changed files
Comments generated: 0
Review effort level: Low

gh-aw-bot · 2026-07-04T15:53:18Z

@copilot please run the pr-finisher skill, review the latest PR state, and rerun checks once the branch is up to date. There are no unresolved review threads right now, so focus on confirming readiness and closing any remaining gaps.

Generated by 👨‍🍳 PR Sous Chef · 14.5 AIC · ⌖ 4.89 AIC · ⊞ 4.4K · ◷
_{Comment /souschef to run again}

Copilot · 2026-07-04T16:04:28Z

@copilot please run the pr-finisher skill, review the latest PR state, and rerun checks once the branch is up to date. There are no unresolved review threads right now, so focus on confirming readin...

Ran the pr-finisher skill. Local validation is fully green:

make fmt ✅
make lint ✅
make test-unit ✅
make test ✅
make recompile ✅ (258/258 workflows compiled)

No unresolved review threads. Branch is up to date with the pushed commits. PR is ready for a human to re-trigger CI and merge.

github-actions · 2026-07-04T16:06:48Z

✅ Design Decision Gate 🏗️ completed the design decision gate check.

github-actions · 2026-07-04T16:06:51Z

🧠 Matt Pocock Skills Reviewer failed during the skills-based review.

Copilot · 2026-07-04T16:28:21Z

@copilot please run the pr-finisher skill, address any outstanding review feedback, refresh the branch if needed, and rerun checks once updated.

...

Ran pr-finisher again. Branch is already up to date (merge commit 8a58cd7). Local validation all green:

make fmt ✅
make lint ✅
make test-unit ✅
make test ✅

No unresolved review threads. PR is ready for a human to re-trigger CI and merge.

github-actions · 2026-07-04T18:46:58Z

🤖 PR Triage — Run §28715668077

Field	Value
Category	`test`
Risk	🟢 Low
Score	52/100
Action	🔄 `batch_review`
Batch	`pr-batch:draft-backlog` (was draft, now open)

Carry-over from prior run. Previously draft, now undrafted. Design Decision Gate requires ADR. Batch with other low-risk test PRs.

Generated by 🔧 PR Triage Agent · 113.5 AIC · ⌖ 13 AIC · ⊞ 5.5K · ◷

gh-aw-bot · 2026-07-04T19:54:52Z

@copilot please run the pr-finisher skill, address any outstanding review feedback, refresh the branch if needed, and rerun checks once updated.

Generated by 👨‍🍳 PR Sous Chef · 6.25 AIC · ⌖ 6.22 AIC · ⊞ 3.4K · ◷
_{Comment /souschef to run again}

…erification-gap Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-07-04T20:04:14Z

@copilot please run the pr-finisher skill, address any outstanding review feedback, refresh the branch if needed, and rerun checks once updated.

...

Branch refreshed with latest main (117370b). Local validation all green (make fmt, make lint, make test-unit, make test). No outstanding review threads. PR is ready for a human to re-trigger CI and merge.

gh-aw-bot · 2026-07-04T20:23:05Z

@copilot please run the pr-finisher skill, review the latest PR state, confirm there are still no unresolved review threads, and post a concise completion summary for maintainers. Local formatting is already clean; focus on readiness and any remaining merge blockers.

Run: https://github.com/github/gh-aw/actions/runs/28718358099

Generated by 👨‍🍳 PR Sous Chef · 13.6 AIC · ⌖ 4.91 AIC · ⊞ 3.4K · ◷
_{Comment /souschef to run again}

Copilot · 2026-07-04T20:28:01Z

@copilot please run the pr-finisher skill, review the latest PR state, confirm there are still no unresolved review threads, and post a concise completion summary for maintainers. Local formatting i...

Completion summary for maintainers

✅ Reviews — No unresolved review threads. Automated reviewer found 0 issues.
✅ Checks (local) — make fmt, make lint, make test-unit, make test, make recompile all pass.
❓ Checks (CI) — Stale after last agent push (3f972d0); needs human re-trigger before merge.
✅ Mergeable — Branch is up to date with origin/main (117370b); working tree clean.

What this PR does: Switches 3 linter tests (stringsindexcontains, sprintfint, stringreplaceminusone) from analysistest.Run → analysistest.RunWithSuggestedFixes and adds golden files to verify the actual text edits produced by each fix builder. No production code changed.

Hand-off: Re-trigger CI (close/reopen, workflow_dispatch, or a maintainer push) then merge when green.

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

gh-aw-bot · 2026-07-04T22:47:59Z

@copilot please run the pr-finisher skill, review the latest PR state, address any remaining review feedback, refresh the branch if needed, rerun checks, and post a concise completion summary for maintainers.

Generated by 👨‍🍳 PR Sous Chef · 6.23 AIC · ⌖ 5.74 AIC · ⊞ 3.4K · ◷
_{Comment /souschef to run again}

Copilot · 2026-07-04T22:55:20Z

@copilot please run the pr-finisher skill, review the latest PR state, address any remaining review feedback, refresh the branch if needed, rerun checks, and post a concise completion summary for ma...

Completion summary for maintainers

✅ Reviews — No unresolved review threads.
✅ Checks (local) — make fmt, make lint, make test-unit, make test all pass.
❓ Checks (CI) — Stale after last push (aeca6bf); needs human re-trigger before merge.
✅ Mergeable — Branch is up to date with origin/main; working tree clean.

Hand-off: Re-trigger CI (close/reopen, workflow_dispatch, or a maintainer push) then merge when green.

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

gh-aw-bot · 2026-07-05T01:58:28Z

@copilot please run the pr-finisher skill, review the latest PR state, address any remaining review feedback, refresh the branch if needed, rerun checks, and post a concise completion summary for maintainers. Focus on the remaining merge blockers: the ADR gate comment indicates this PR still needs a linked ADR in the PR body, and CI will likely need a maintainer re-trigger once that is in place.

Generated by 👨‍🍳 PR Sous Chef · 10.4 AIC · ⌖ 6.49 AIC · ⊞ 6.8K · ◷
_{Comment /souschef to run again}

Copilot · 2026-07-05T02:06:18Z

@copilot please run the pr-finisher skill, review the latest PR state, address any remaining review feedback, refresh the branch if needed, rerun checks, and post a concise completion summary for ma...

The ADR file is already committed on the branch at docs/adr/43376-switch-linter-tests-to-runwithsuggestedfixes.md. The gate requires it to be linked in the PR body as well, but I cannot update the PR body from this context.

A maintainer needs to add the following line to the PR body (e.g. after the "No production analyzer code changed." line):

## ADR

ADR: [ADR-43376: Switch Linter Tests to RunWithSuggestedFixes](docs/adr/43376-switch-linter-tests-to-runwithsuggestedfixes.md)

Once the PR body is updated the ADR gate can be re-triggered. Local validation remains fully green; no code changes are needed.

Summary:

✅ Reviews — No unresolved threads.
✅ Checks (local) — make fmt, make lint, make test-unit, make test all pass.
❓ Checks (CI) — Stale; needs re-trigger after PR body update.
❌ Mergeable — ADR gate blocking: PR body missing ADR link (file exists on branch). Needs maintainer edit + CI re-trigger.

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

#43376) Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions · 2026-07-07T10:08:27Z

🎉 This pull request is included in a new release.

Release: v0.82.3

Initial plan

b47dd31

Copilot AI assigned Copilot and pelikhan Jul 4, 2026

Copilot started work on behalf of pelikhan July 4, 2026 11:13 View session

Copilot AI linked an issue Jul 4, 2026 that may be closed by this pull request

Autofix verification-parity gap: 3 of 9 SuggestedFix linters (stringsindexcontains, sprintfint, stringreplaceminusone) have zero [Content truncated due to length] #43313

Closed

4 tasks

Copilot AI and others added 2 commits July 4, 2026 11:17

Initial plan: add golden files and switch to RunWithSuggestedFixes fo…

05213b9

…r 3 linters Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Add golden files and switch to RunWithSuggestedFixes for stringsindex…

8c890eb

…contains, sprintfint, stringreplaceminusone Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix verification gap for 3 SuggestedFix linters~~ test: add golden files and RunWithSuggestedFixes for 3 autofix linters Jul 4, 2026

Copilot AI requested a review from pelikhan July 4, 2026 11:23

Copilot finished work on behalf of pelikhan July 4, 2026 11:23

github-actions Bot mentioned this pull request Jul 4, 2026

[aw] No-Op Runs #39849

Closed

github-actions Bot added pr-action:batch_review pr-agent:copilot-swe-agent pr-priority:medium pr-risk:low pr-type:test pr-batch:draft-backlog labels Jul 4, 2026

github-actions Bot mentioned this pull request Jul 4, 2026

[PR Triage Report] 🤖 PR Triage Report — 2026-07-04 [Run §28706384347] #43385

Closed

pelikhan marked this pull request as ready for review July 4, 2026 15:44

Copilot AI review requested due to automatic review settings July 4, 2026 15:44

Copilot started reviewing on behalf of pelikhan July 4, 2026 15:44 View session

Copilot AI reviewed Jul 4, 2026

View reviewed changes

Copilot started work on behalf of gh-aw-bot July 4, 2026 15:53 View session

Copilot finished work on behalf of gh-aw-bot July 4, 2026 16:04

Copilot AI requested a review from gh-aw-bot July 4, 2026 16:04

Copilot finished work on behalf of gh-aw-bot July 4, 2026 16:28

github-actions Bot mentioned this pull request Jul 4, 2026

[PR Triage Report] 🤖 PR Triage Report — 2026-07-04 (Run §28715668077) #43427

Closed

Copilot started work on behalf of gh-aw-bot July 4, 2026 19:55 View session

Copilot AI and others added 2 commits July 4, 2026 20:00

Merge remote-tracking branch 'origin/main' into copilot/fix-autofix-v…

285e1c1

…erification-gap Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into copilot/fix-autofix-v…

3f972d0

…erification-gap Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot July 4, 2026 20:04

Copilot started work on behalf of gh-aw-bot July 4, 2026 20:23 View session

Apply remaining changes

aeca6bf

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot July 4, 2026 20:28

Copilot started work on behalf of gh-aw-bot July 4, 2026 22:48 View session

Apply remaining changes

7d9a907

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot July 4, 2026 22:55

Copilot started work on behalf of gh-aw-bot July 5, 2026 01:58 View session

Apply remaining changes

7e264fa

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot July 5, 2026 02:06

pelikhan merged commit 2fd963e into main Jul 5, 2026
29 checks passed

pelikhan deleted the copilot/fix-autofix-verification-gap branch July 5, 2026 03:50

Copilot AI added a commit that referenced this pull request Jul 5, 2026

test: add golden files and RunWithSuggestedFixes for 3 autofix linters (

427242d

#43376) Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions Bot mentioned this pull request Jul 5, 2026

[PR Triage Report] PR Triage Report — Run #7 (2026-07-05) #43502

Closed

Uh oh!

Conversation

Copilot AI commented Jul 4, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

github-actions Bot commented Jul 4, 2026

🤖 PR Triage — Run §28706384347

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

gh-aw-bot commented Jul 4, 2026

Uh oh!

Copilot AI commented Jul 4, 2026

Uh oh!

github-actions Bot commented Jul 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI commented Jul 4, 2026

Uh oh!

github-actions Bot commented Jul 4, 2026

🤖 PR Triage — Run §28715668077

Uh oh!

gh-aw-bot commented Jul 4, 2026

Uh oh!

Copilot AI commented Jul 4, 2026

Uh oh!

gh-aw-bot commented Jul 4, 2026

Uh oh!

Copilot AI commented Jul 4, 2026

Uh oh!

gh-aw-bot commented Jul 4, 2026

Uh oh!

Copilot AI commented Jul 4, 2026

Uh oh!

gh-aw-bot commented Jul 5, 2026

Uh oh!

Copilot AI commented Jul 5, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Jul 4, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Jul 4, 2026 •

edited

Loading

github-actions Bot commented Jul 4, 2026 •

edited

Loading